Skip to content

STRATCONN-6536-Register new memora-internal destination#3565

Open
nk1107 wants to merge 4 commits intomainfrom
create-memora-internal
Open

STRATCONN-6536-Register new memora-internal destination#3565
nk1107 wants to merge 4 commits intomainfrom
create-memora-internal

Conversation

@nk1107
Copy link
Contributor

@nk1107 nk1107 commented Feb 4, 2026

This pull request adds new memora-internal action-destination which will be used to create memora connections. This new internal destination has exact same behaviour as the external memora action-destination but this will be hidden in UI.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

  • Extracted all action API versions to verioning-info.ts file. example

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Memora Internal, Settings:username,password
  • Destination: Memora Internal, Action:upsertProfile, Fields:memora_store,contact_identifiers

Add these new fields as optional instead and assume default values in perform or performBatch block.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.25%. Comparing base (fb57e36) to head (cd8fe8a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3565      +/-   ##
==========================================
- Coverage   80.64%   80.25%   -0.40%     
==========================================
  Files        1579     1276     -303     
  Lines       30382    23485    -6897     
  Branches     6506     4697    -1809     
==========================================
- Hits        24503    18848    -5655     
+ Misses       4994     3762    -1232     
+ Partials      885      875      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nk1107 nk1107 force-pushed the create-memora-internal branch from 8a6e6a7 to 6447dc5 Compare February 5, 2026 04:17
@nk1107 nk1107 requested a review from varadarajan-tw February 5, 2026 04:46
@nk1107 nk1107 changed the title Register new memora-internal destination STRATCONN-6536-Register new memora-internal destination Feb 5, 2026
@nk1107 nk1107 force-pushed the create-memora-internal branch from 6447dc5 to cd8fe8a Compare February 5, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants